Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Location to look up by name/parent #287

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

joewesch
Copy link
Contributor

@joewesch joewesch commented Dec 1, 2023

This changes all location options to accept either a UUID, a name as a str or a dict of name and parent.

Closes: #286

@jvanderaa
Copy link
Contributor

Let's put this as a new major version with the change to a dictionary on the parent.

Copy link
Contributor

@pszulczewski pszulczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joewesch
Copy link
Contributor Author

joewesch commented Dec 4, 2023

Let's put this as a new major version with the change to a dictionary on the parent.

It's not a dict, it's raw, which still accepts a string and is backwards compatible.

@joewesch joewesch merged commit b589e27 into nautobot:develop Dec 4, 2023
8 checks passed
@joewesch joewesch deleted the 286_location-search branch December 4, 2023 20:35
@cardoe
Copy link

cardoe commented Jan 10, 2024

So if you use the str instead of the UUID it will report as changed every time. Is that intended?

@joewesch
Copy link
Contributor Author

So if you use the str instead of the UUID it will report as changed every time. Is that intended?

No, that was not intended. If you are experiencing this please open a new issue with the details and we can investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error creating rack_group with location name: Location needs a valid UUID
4 participants