Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data sub dictionary and move everything to top level #66

Merged
merged 23 commits into from
Aug 5, 2021
Merged

Remove data sub dictionary and move everything to top level #66

merged 23 commits into from
Aug 5, 2021

Conversation

FragmentedPacket
Copy link
Contributor

Fixes #58

  • Remove custom NautobotAnsibleModule that was being used for custom validation due to having nested data
  • Accept within NatubotModule argument for which keys to remove for payload
  • Create _build_payload to remove unnecessary keys to send to Nautobot
  • Fix documentation string
  • Fix arg spec for change in data

TODO:

  • Unit test for _build_payload
  • True up unit test data for passing in new module args
  • True up all other modules (should be pretty easy lift and shift)
  • Integration tests (separate PR due to size and integration tests not existing at the moment)

…keys for payload, and test on the device module.
jvanderaa
jvanderaa previously approved these changes Aug 4, 2021
Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested for semantic versioning since this will be a breaking change.

galaxy.yml Outdated Show resolved Hide resolved
@FragmentedPacket FragmentedPacket merged commit af5f7b3 into nautobot:develop Aug 5, 2021
@FragmentedPacket FragmentedPacket deleted the 58-ansible4.0-changes branch August 5, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Modules For Verification Changes
3 participants