GH action ready for review #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubajze
requested review from
FragmentedPacket,
jmcgill298 and
jvanderaa
as code owners
jvanderaa
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
This looks to match what we have today on Travis. Let's make sure that @FragmentedPacket approves as well before merging.
We are also going to need to add a recurring CI execution to have this whole thing run weekly as well.
| - name: "Build the collection" | ||
| run: "ansible-galaxy collection build --output-path build" | ||
| - name: "Publish the collection" | ||
| run: "ansible-galaxy collection publish build/* --api-key=${{ secrets.GALAXY_API_TOKEN }}" |
There was a problem hiding this comment.
@FragmentedPacket will this work out for the publishing?
There was a problem hiding this comment.
I believe it should work, but would try and test locally.
Here is what I did in the Netbox collection a while ago: https://github.com/netbox-community/ansible_modules/blob/devel/.github/workflows/release.yml#L16
FragmentedPacket
approved these changes
Sep 10, 2021
|
I'm good using the Ansible Galaxy command. It is known and works. @FragmentedPacket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.