Add usage of letters for rendering FP SVG.

[pszulczewski]

This draft adds only SVG rendering options to use letters or numbers for the grid numbering axis labels.
Selecting letters for the X axis will make the FP look like a chessboard.

The downside is that for adding tiles it still uses numbers, because FloorPlanTile model x_origin and y_origin fields are now PositiveSmallIntegerField.

Potentially form could be changed to present numbers or letters for tile origins, and under clean() it could be covered back to numbers.

[joewesch]

Potentially form could be changed to present numbers or letters for tile origins, and under clean() it could be covered back to numbers.

I like this idea. Let's do it!

[itdependsnetworks]

I had mentioned that we should consider having a generator for the increment #8 (comment)

[pszulczewski]

The latest commit is to support letters in the tile form.

@itdependsnetworks I am fine with implementing generator if @joewesch allows more time.

[joewesch]

I had mentioned that we should consider having a generator for the increment

I like the idea, but I think what we have so far will be a good start as I believe it covers at least 80% of use cases. Let's count this as incremental progress toward the eventual goal and not mark this as closing/resolving the issue.

[pszulczewski]

I am still thinking if keeping x/y grid setting per object will give good user experience? Maybe it should be a global plugin setting, which is selected only once?

[joewesch]

I am still thinking if keeping x/y grid setting per object will give good user experience? Maybe it should be a global plugin setting, which is selected only once?

Yes, a plugin setting default would be great, but still allow for grid specific override. Our client uses different grid patterns per Location.

[pszulczewski]

What is the changelog in the CI? I am not sure why it fails?

[joewesch]

What is the changelog in the CI? I am not sure why it fails?

This repo uses towncrier and requires a changelog fragment file: https://docs.nautobot.com/projects/floor-plan/en/latest/dev/contributing/#creating-changelog-fragments

[pszulczewski]

What is the changelog in the CI? I am not sure why it fails?

This repo uses towncrier and requires a changelog fragment file: https://docs.nautobot.com/projects/floor-plan/en/latest/dev/contributing/#creating-changelog-fragments

Thanks. Looks like my branch was checked out beginning of February and it didn't have changes directory.
I've just re-based on develop and added a change file.

[joewesch]

Patryk, something isn't working right with the edit form. If I set one (or both) of the labels to letters and then edit the floor plan, the form field defaults back to numbers.

[joewesch]

When setting a label to use letters, but then putting a number in the form it raise an inconsistent error message:

As part of the clean method we should do one of the following:

• Check for an inconsistent type and raise the appropriate error
• Automatically cast the number or letter to the proper value (my preferred option - save people from their own mistakes)

[pszulczewski]

Let me check that.

[pszulczewski]

Patryk, something isn't working right with the edit form. If I set one (or both) of the labels to letters and then edit the floor plan, the form field defaults back to numbers.

Looks like it stopped working after changing form field to CharField.
I fixed that and added validations. Should be good now, can you please pull and re-test?

[pszulczewski]

@joewesch I have added unittests for the FloorPlanTileForm because there weren't any for that form, and they revealed that there were still some issues. I've made the necessary updates in forms, we should be good now.

[joewesch]

Looks and works great now, thanks Patryk!

[joewesch]

@glennmatthews would you mind giving this a once over?

[glennmatthews]

Can you elaborate on this? I'd think that if the validator fails we should fail model clean?

[pszulczewski]

I was thinking to raise ValidationError in here and I was expecting that it will stop here, but what happens is that ValidationError exception is raised silently and it still goes to the model .clean() method, where it causes exception on the > operator TypeError: '>' not supported between instances of 'str' and 'int', what results with an exception page in the UI.