Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage of letters for rendering FP SVG. #79
Add usage of letters for rendering FP SVG. #79
Changes from 14 commits
459b0de
4a249e2
ae3302b
fd5005a
b2bbd4a
2a2eff2
2e39c9f
94b409e
f94234f
1158426
a2f647e
6a0bf18
c294489
5b062b6
8d5a26b
a757770
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this? I'd think that if the validator fails we should fail model clean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to raise
ValidationError
in here and I was expecting that it will stop here, but what happens is thatValidationError
exception is raised silently and it still goes to the model .clean() method, where it causes exception on the>
operatorTypeError: '>' not supported between instances of 'str' and 'int'
, what results with an exception page in the UI.