Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8 Add grid seed option for FloorPlan #106

Merged
merged 14 commits into from
Aug 7, 2024

Conversation

nopg
Copy link
Contributor

@nopg nopg commented Jul 23, 2024

Allow user to add a 'seed' to begin the grid numbering. Works for numbers or letters. Allows origin to now also be '0'.

This does not allow for a custom 'increment' (yet?!)

Copy link
Contributor

@joewesch joewesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass...

nautobot_floor_plan/forms.py Outdated Show resolved Hide resolved
nautobot_floor_plan/forms.py Outdated Show resolved Hide resolved
nautobot_floor_plan/forms.py Outdated Show resolved Hide resolved
@nopg
Copy link
Contributor Author

nopg commented Jul 24, 2024

Made all changes requested, added change fragment and ran black to fix the black/flake8 issues.

@joewesch joewesch linked an issue Jul 25, 2024 that may be closed by this pull request
@joewesch
Copy link
Contributor

This is another partial completion for the custom start and increment on the floor plans for issue #8

@joewesch joewesch requested a review from glennmatthews July 25, 2024 21:04
Copy link
Collaborator

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like the concept here but I have some concerns about the resilience of this when updating a floor plan with multiple existing tiles. See comments.

nautobot_floor_plan/models.py Outdated Show resolved Hide resolved
nautobot_floor_plan/models.py Outdated Show resolved Hide resolved
nautobot_floor_plan/models.py Outdated Show resolved Hide resolved
nautobot_floor_plan/models.py Outdated Show resolved Hide resolved
nautobot_floor_plan/tests/test_models.py Outdated Show resolved Hide resolved
@nopg
Copy link
Contributor Author

nopg commented Aug 1, 2024

Thanks, all changes now implemented as requested in the latest push.

@nopg nopg force-pushed the u/nopg-0008-grid_seed branch from 2e4c245 to 032ee42 Compare August 1, 2024 22:22
@joewesch joewesch requested a review from glennmatthews August 7, 2024 17:10
@joewesch joewesch merged commit 1791e67 into nautobot:develop Aug 7, 2024
16 checks passed
@nopg nopg deleted the u/nopg-0008-grid_seed branch August 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants