-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8 Add grid seed option for FloorPlan #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass...
nautobot_floor_plan/templates/nautobot_floor_plan/floorplan_retrieve.html
Outdated
Show resolved
Hide resolved
Made all changes requested, added change fragment and ran black to fix the black/flake8 issues. |
This is another partial completion for the custom start and increment on the floor plans for issue #8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like the concept here but I have some concerns about the resilience of this when updating a floor plan with multiple existing tiles. See comments.
Thanks, all changes now implemented as requested in the latest push. |
2e4c245
to
032ee42
Compare
Allow user to add a 'seed' to begin the grid numbering. Works for numbers or letters. Allows origin to now also be '0'.
This does not allow for a custom 'increment' (yet?!)