Djhoward12 naaps 124 child tabs #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 25, 2024 13:12
…le in tables. Added count of child floor plans to floor_plan view.
…nvoke exiting early
joewesch
reviewed
Dec 3, 2024
nautobot_floor_plan/templates/nautobot_floor_plan/floorplan_retrieve.html
Outdated
Show resolved
Hide resolved
nautobot_floor_plan/templates/nautobot_floor_plan/location_child_floor_plan.html
Outdated
Show resolved
Hide resolved
joewesch
reviewed
Dec 3, 2024
joewesch
reviewed
Dec 3, 2024
|
This PR resolves the dependabot issue being resolved in PR 138 |
joewesch
approved these changes
Dec 11, 2024
smk4664
approved these changes
Dec 13, 2024
| @@ -0,0 +1,16 @@ | |||
| {% extends "dcim/location.html" %} | |||
There was a problem hiding this comment.
@glennmatthews When we start removing the object templates in favor of the Python template generation, will this be a problem? I am not asking DJ to change this, just curious how future changes in Nautobot would impact this.
There was a problem hiding this comment.
At some point, yeah, this will need to change to just being based on generic/object_retrieve.html (or adopt the UI Component Framework itself). For now we're keeping and just hollowing out the core templates (rather than deleting them entirely) to avoid exactly this problem in 2.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.