Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add napalm/netmiko extras support to plugin config #45

Merged
merged 58 commits into from
Jan 31, 2022
Merged

Add napalm/netmiko extras support to plugin config #45

merged 58 commits into from
Jan 31, 2022

Conversation

jeffkala
Copy link
Contributor

fixes #40

Read in extras from plugin config and populate them into the nornir play for use.

@jeffkala
Copy link
Contributor Author

jeffkala commented Jan 6, 2022

@itdependsnetworks @dgarros is this what we were looking for on this one?

@itdependsnetworks
Copy link
Contributor

I believe this is correct. @dgarros any thoughts?

README.md Outdated Show resolved Hide resolved
nautobot_plugin_nornir/plugins/inventory/nautobot_orm.py Outdated Show resolved Hide resolved
@jeffkala jeffkala requested a review from dgarros January 7, 2022 20:31
jeffkala and others added 2 commits January 10, 2022 08:39
Co-authored-by: Ken Celenza <ken@celenza.org>
Copy link

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @jeffkala

README.md Outdated Show resolved Hide resolved
@jeffkala jeffkala marked this pull request as draft January 22, 2022 15:12
@itdependsnetworks itdependsnetworks changed the base branch from develop to main January 25, 2022 02:52
@itdependsnetworks itdependsnetworks changed the base branch from main to develop January 25, 2022 02:52
@jeffkala jeffkala marked this pull request as ready for review January 27, 2022 15:18
@jeffkala
Copy link
Contributor Author

Anything else for this one @itdependsnetworks

@itdependsnetworks itdependsnetworks merged commit 331a128 into nautobot:develop Jan 31, 2022
@jeffkala jeffkala deleted the jkala-extras branch March 9, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to provide extra netmiko and Napalm settings
3 participants