Skip to content

Commit

Permalink
Merge pull request #662 from nautobot/develop
Browse files Browse the repository at this point in the history
Fix CI in Main for 3.4.0
  • Loading branch information
jdrew82 authored Jan 15, 2025
2 parents bd20c20 + b8a532e commit 699d949
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions changes/656.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed missing manufacturers for OPNsense and CyberPower.
1 change: 1 addition & 0 deletions changes/659.housekeeping
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Temporarily disable test_as_form() test that's breaking CI until bug in core is fixed.
3 changes: 3 additions & 0 deletions nautobot_ssot/integrations/librenms/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"ping": "Generic",
"hpe-ilo": "HP",
"proxmox": "Proxmox",
"opnsense": "Opnsense",
# Types from LibreNMS/OS php files
"aen": "Accedian OS",
"airos": "Ubiquiti",
Expand Down Expand Up @@ -65,6 +66,7 @@
"comware": "HPE",
"coriant": "Coriant",
"cumulus": "Cumulus Networks",
"cyberpower": "CyberPower",
"danthermos": "Dantherm",
"ddwrt": "DD-WRT",
"deliberant": "Deliberant",
Expand Down Expand Up @@ -232,6 +234,7 @@
# Other Types
"Proxmox": ["proxmox"],
"Generic": ["generic", "ping"],
"Opnsense": ["opnsense"],
# Types imported from LibreNMS/OS php files
"4RF": ["aprisa"],
"3Com": ["threecom"],
Expand Down
3 changes: 3 additions & 0 deletions nautobot_ssot/tests/test_jobs.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Test the Job classes in nautobot_ssot."""

import os.path
from unittest import skip
from unittest.mock import Mock, call, patch

from django.db.utils import IntegrityError, OperationalError
Expand Down Expand Up @@ -58,6 +59,8 @@ def test_sync_log(self):

self.assertEqual(2, SyncLogEntry.objects.count())

# TODO: Re-enable this test once the bug in core is fixed.
@skip
def test_as_form(self):
"""Test the as_form() method."""
form = self.job.as_form()
Expand Down

0 comments on commit 699d949

Please sign in to comment.