Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move existing integrations to use external integration / controller pattern #459

Closed
Kircheneer opened this issue May 21, 2024 · 5 comments · Fixed by #471
Closed

Move existing integrations to use external integration / controller pattern #459

Kircheneer opened this issue May 21, 2024 · 5 comments · Fixed by #471
Assignees
Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: device42 Issues/PRs for Device42 Integration integration: ipfabric Issues/PRs for IPFabric integration integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: enhancement New feature or request
Milestone

Comments

@Kircheneer
Copy link
Contributor

Proposed Functionality

CVP, DNAC and Infoblox are already or will be soon using the external integration and/or controller models from Nautobot 2.1/2.2 respectively. The other integrations should follow this pattern.

@Kircheneer Kircheneer added this to the 3.0.0 milestone May 21, 2024
@jdrew82 jdrew82 self-assigned this May 21, 2024
@jdrew82 jdrew82 added type: enhancement New feature or request integration: servicenow Issues originally from standalone ServiceNow SSoT repo integration: ciscoaci Issues/PRs for Cisco ACI integration. integration: ipfabric Issues/PRs for IPFabric integration integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: device42 Issues/PRs for Device42 Integration labels May 21, 2024
@jdrew82
Copy link
Contributor

jdrew82 commented May 21, 2024

To be clear, we'll be updating the following integrations to use either ExternalIntegration or Controller objects:

ACI - Controller
CVP - Controller
D42 - ExternalIntegration
IPFabric - Controller

@Kircheneer
Copy link
Contributor Author

Thanks for elaborating!

@jdrew82
Copy link
Contributor

jdrew82 commented Jul 29, 2024

After some discussion we've decided to not update the Arista CloudVision integration as it already uses ExternalIntegration and trying to update to Controller would be too complicated at this time.

@jdrew82
Copy link
Contributor

jdrew82 commented Aug 14, 2024

We've agreed to also not update the IPFabric integration to use the Controller due to how the current setup is using the instance credentials to pull snapshots in the Job form. Updating to be dynamically queried based upon the Controller will require some custom Javascript and possibly overriding the Job form which is out of scope at this time.

@jdrew82
Copy link
Contributor

jdrew82 commented Aug 20, 2024

Integrations have been updated in next branch and will be included in 3.0 release.

@jdrew82 jdrew82 closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: device42 Issues/PRs for Device42 Integration integration: ipfabric Issues/PRs for IPFabric integration integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants