Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Integrations for Controllers/ExternalIntegration #471

Merged
merged 49 commits into from
Aug 20, 2024
Merged

Update Integrations for Controllers/ExternalIntegration #471

merged 49 commits into from
Aug 20, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Jun 21, 2024

This PR is to include all the changes required to update the integrations to use either Controller or ExternalIntegration. Closes #459.

@jdrew82 jdrew82 added type: enhancement New feature or request integration: servicenow Issues originally from standalone ServiceNow SSoT repo integration: infoblox Issues/PRs for Infoblox integration integration: ciscoaci Issues/PRs for Cisco ACI integration. integration: ipfabric Issues/PRs for IPFabric integration integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: device42 Issues/PRs for Device42 Integration integration: dna center Issues/PRs for Cisco DNA Center integration. labels Jun 21, 2024
@jdrew82 jdrew82 added this to the 3.0.0 milestone Jun 21, 2024
@jdrew82 jdrew82 self-assigned this Jun 21, 2024
@jdrew82 jdrew82 requested review from alhogan, a team and chadell as code owners June 21, 2024 17:48
@jdrew82 jdrew82 linked an issue Jun 21, 2024 that may be closed by this pull request
Move existing integrations to use external integration / controller pattern #459
Closed
@jdrew82 jdrew82 removed the integration: dna center Issues/PRs for Cisco DNA Center integration. label Jun 21, 2024
@jdrew82 jdrew82 changed the title Update Integrations for Controllers/ExternalIntegration [WIP] Update Integrations for Controllers/ExternalIntegration Jun 21, 2024
@jdrew82 jdrew82 marked this pull request as draft June 21, 2024 17:50
@mzbroch
Copy link
Contributor

mzbroch commented Jul 31, 2024

Great work!
Regarding ACI, I think we can improve existing method of tagging of all objects with $self.site_tag. This is not very useful if many APIC controllers are located within the same Location (ie. DC1).
I though, we could define new $sync_tag=something variable under Controller's External Integration settings. That would be an optional setting that would allow us to define a single tag per controller.

@jdrew82 jdrew82 force-pushed the feat-controllers_extintegrations branch from 7bc5db8 to b218882 Compare August 13, 2024 19:59
@jdrew82 jdrew82 changed the title [WIP] Update Integrations for Controllers/ExternalIntegration Update Integrations for Controllers/ExternalIntegration Aug 14, 2024
@jdrew82 jdrew82 force-pushed the feat-controllers_extintegrations branch from b4d3e1f to 6ca3b4f Compare August 14, 2024 18:54
@jdrew82
Copy link
Contributor Author

jdrew82 commented Aug 14, 2024

Great work! Regarding ACI, I think we can improve existing method of tagging of all objects with $self.site_tag. This is not very useful if many APIC controllers are located within the same Location (ie. DC1). I though, we could define new $sync_tag=something variable under Controller's External Integration settings. That would be an optional setting that would allow us to define a single tag per controller.

Did you still want to try and include this change or can it be done after the 3.0 release?

Kircheneer
Kircheneer requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things, good apart from that

Kircheneer
Kircheneer approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Kircheneer Kircheneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdrew82 jdrew82 merged commit 6d59229 into next Aug 20, 2024
16 checks passed
@jdrew82 jdrew82 deleted the feat-controllers_extintegrations branch August 20, 2024 19:20
@jdrew82 jdrew82 mentioned this pull request Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzbroch mzbroch mzbroch left review comments

@Kircheneer Kircheneer Kircheneer approved these changes

@alhogan alhogan Awaiting requested review from alhogan

@chadell chadell Awaiting requested review from chadell

@glennmatthews glennmatthews Awaiting requested review from glennmatthews

@qduk qduk Awaiting requested review from qduk

Assignees

@jdrew82 jdrew82

Labels
integration: ciscoaci Issues/PRs for Cisco ACI integration. integration: cloudvision Issues/PRs for the Arista CloudVision SSoT integration. integration: device42 Issues/PRs for Device42 Integration integration: infoblox Issues/PRs for Infoblox integration integration: ipfabric Issues/PRs for IPFabric integration integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Move existing integrations to use external integration / controller pattern
4 participants
@jdrew82 @mzbroch @Kircheneer @mattmiller87