Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Integrations for Controllers/ExternalIntegration #471

Merged
merged 49 commits into from
Aug 20, 2024
Merged

Update Integrations for Controllers/ExternalIntegration #471

merged 49 commits into from
Aug 20, 2024

Commits on Aug 14, 2024

  1. Update Diffsync to 2.0.0 and perform Linting

    @mattmiller87 @jdrew82
    mattmiller87 authored and jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    393ce75 View commit details
    Browse the repository at this point in the history

  2. fix: 🐛 Replace all instances of diffsync attributes with adapter.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1a852c7 View commit details
    Browse the repository at this point in the history

  3. build: ⬆️ Rebuild and update dependencies for lockfile.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    44bb869 View commit details
    Browse the repository at this point in the history

  4. refactor: 🔥 Remove tenant_prefix from NautobotAdapter as it's unused.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2411206 View commit details
    Browse the repository at this point in the history

  5. feat: ✨ Update ACI integration to use Controller model.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c36f3cf View commit details
    Browse the repository at this point in the history

  6. build: ⬆️ Make Nautobot 2.2.0 minimum supported version.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6dad7f1 View commit details
    Browse the repository at this point in the history

  7. fix: 🔥 Remove unused import

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c785eb9 View commit details
    Browse the repository at this point in the history

  8. feat: ✨ Update Device42 integration to use ExternalIntegration.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fdfde1f View commit details
    Browse the repository at this point in the history

  9. refactor: 🔥 Remove aci_apics default_setting as no longer needed.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fe83472 View commit details
    Browse the repository at this point in the history

  10. docs: 📝 Update ACI docs to reference Controller/ExternalIntegration u… 

    …pdate.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1c2be56 View commit details
    Browse the repository at this point in the history

  11. feat: ✨ Update IPFabric integration to use Controller object.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    077708b View commit details
    Browse the repository at this point in the history

  12. build: 🔥 Remove unused config settings for ACI integration.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7610d4a View commit details
    Browse the repository at this point in the history

  13. build: 🔥 Remove IPFabric settings that are no longer used.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    510143a View commit details
    Browse the repository at this point in the history

  14. fix: 🐛 Correct default booleans to be strings.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    24d4ad8 View commit details
    Browse the repository at this point in the history

  15. refactor: ♻️ Update Nautobot Host to be pulled from env var directly.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    04e3622 View commit details
    Browse the repository at this point in the history

  16. refactor: 🔥 Remove unused env vars

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f20262b View commit details
    Browse the repository at this point in the history

  17. docs: 📝 Update IPFabric documentation about using Controller/External… 

    …Integration.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7931e54 View commit details
    Browse the repository at this point in the history

  18. feat: ✨ Add support for ControllerManagedDeviceGroup in ACI integration. 

    Added required pieces for the ControllerManagedDeviceGroup for the associated Controller is attached to the imported Devices.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8e1184d View commit details
    Browse the repository at this point in the history

  19. refactor: ♻️ Move code to get username/password from HTTP SecretsGrou… 

    …p to utility function.

This required moving logging import around for integration utils and the App config portion due to errors around Apps not installed yet.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1127766 View commit details
    Browse the repository at this point in the history

  20. feat: ✨ Update SSoT ChatOps command to use or request a Controller fo… 

    …r the Job.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d6f187b View commit details
    Browse the repository at this point in the history

  21. test: 🚨 Address various linter complaints.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f3f3f33 View commit details
    Browse the repository at this point in the history

  22. refactor: ♻️ Move ControllerManagedDeviceGroup validation to utility … 

    …function and update ACI integration.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    80a8430 View commit details
    Browse the repository at this point in the history

  23. style: Add help text to device_site Job var.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4433ec9 View commit details
    Browse the repository at this point in the history

  24. fix: 🐛 Correct remote_url and verify_ssl to come from ExternalIntegra… 

    …tion on Controller.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    2db18d1 View commit details
    Browse the repository at this point in the history

  25. fix: 🐛 Correct errors caused by rebase

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9da9a20 View commit details
    Browse the repository at this point in the history

  26. fix: 🐛 Fix ACI signals to only try to iterate through APICs if they'r… 

    …e defined.

This fixes the issue where Nautobot won't start if ACI integration is enabled but no APICs are defined.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fbd0695 View commit details
    Browse the repository at this point in the history

  27. fix: 🐛 Correct ObjectVar to use description instead of help_text.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e69216a View commit details
    Browse the repository at this point in the history

  28. fix: 🐛 Move client initialization to dunder init as init_ipf_client n… 

    …ow requires self to be passed for the Controller.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    fdd9b3c View commit details
    Browse the repository at this point in the history

  29. style: 🚨 Sort imports

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    8eddb26 View commit details
    Browse the repository at this point in the history

  30. style: Change ordering of Job vars so Controller is first selection.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4b9cb2d View commit details
    Browse the repository at this point in the history

  31. fix: 🐛 Add check for existing ControllerManagedDeviceGroup on selecte… 

    …d Controller.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ba32ca7 View commit details
    Browse the repository at this point in the history

  32. feat: ✨ Add controller_group attribute to Device DiffSyncModel to con… 

    …nect imported Devices to group.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    05f2ff5 View commit details
    Browse the repository at this point in the history

  33. style: 🚨 Sort imports with ruff

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c5bdb43 View commit details
    Browse the repository at this point in the history

  34. style: 🚨 Formatting for black

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c98e15a View commit details
    Browse the repository at this point in the history

  35. revert: ⏪️ Revert IPFabric integration changes for adding Controller.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    abf54a0 View commit details
    Browse the repository at this point in the history

  36. build: ⬆️ Update project dependencies lockfile

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1bc39ac View commit details
    Browse the repository at this point in the history

  37. test: 🚨 Remove unused import

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f7b3170 View commit details
    Browse the repository at this point in the history

  38. build: ⏪️ Revert minimum Nautobot to 2.1.0

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    207c026 View commit details
    Browse the repository at this point in the history

  39. build: 📌 Pin django-debug-toolbar to version less than 4.4

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    6ca3b4f View commit details
    Browse the repository at this point in the history

  40. feat: ✨ Add checks for ExternalIntegration on Controller and SecretsG… 

    …roup on ExternalIntegration.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9cf8a93 View commit details
    Browse the repository at this point in the history

  41. fix: 🐛 Add default value for tenant_prefix in case not defined in ext… 

    …ra_config.
    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    de58745 View commit details
    Browse the repository at this point in the history

  42. fix: 🐛 Correct var to be client.site instead of using dict key.

    @jdrew82
    jdrew82 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a4409ad View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. fix: 🐛 Remove duplicate lines from rebase.

    @jdrew82
    jdrew82 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8df0631 View commit details
    Browse the repository at this point in the history

  2. docs: 📝 Update Device42 Documentation with screenshots of ExternalInt… 

    …egration.
    @jdrew82
    jdrew82 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c3415d0 View commit details
    Browse the repository at this point in the history

  3. docs: ⏪️ Revert documentation changes for IPFabric integration.

    @jdrew82
    jdrew82 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9d84163 View commit details
    Browse the repository at this point in the history

  4. revert: ⏪️ Revert any changes to ChatOps command for Controller in IP… 

    …Fabric integration.
    @jdrew82
    jdrew82 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b752eef View commit details
    Browse the repository at this point in the history

  5. fix: 🐛 Correct NB minimum version to 2.1.0 to match pyproject.toml an… 

    …d add ACI integration to _MIN_NAUTOBOT_VERSION.
    @jdrew82
    jdrew82 committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2e1b146 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. fix: ⏪️ Remove missed portions of container additions to IPFabric wor… 

    …ker command.
    @jdrew82
    jdrew82 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    718b495 View commit details
    Browse the repository at this point in the history

  2. test: ✅ Adjust variable names to not conflict with vars in function a… 

    …nd refactor to fix failing test.
    @jdrew82
    jdrew82 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    17e3acc View commit details
    Browse the repository at this point in the history