IPFabric integration settings updates #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alhogan
commented
Oct 13, 2023
•
alhogan
commented
- Cleans up references to configuration settings in code
- Updates configuration settings names to ensure no conflicts and adhere to standards
- Adds additional documentation around required and optional configuration settings
- Fixes a few incorrect defaults for safe delete mode statuses
- Closes SSoT NAUTOBOT - IPFABRIC: django.core.exceptions.ValidationError #240
- All config settings are now prefixed "ipfabric_" - All config settings are loaded in `constants.py` for reference - Fixed incorrect safe delete mode statuses
- Added section on required settings - Added section on optional settings - Added warnings for updated setting names
alhogan
changed the title
chadell
reviewed
Oct 16, 2023
chadell
requested changes
Oct 16, 2023
chadell
approved these changes
Oct 17, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.