Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for lookups that span relationships in TypedDict #302

Closed
wants to merge 1 commit into from

Conversation

gioccher
Copy link

This PR addresses #295 by adding support for lookups that span relationships in TypedDict

@gioccher gioccher requested a review from a team as a code owner December 11, 2023 21:27
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @Kircheneer does this make sense to you?

@Kircheneer
Copy link
Contributor

Sorry that I didn't get back to this yet. I would like to document limitations here, as we are addressing this for foreign keys but not for e.g. reverse foreign keys. And I would like to add some error handling

@Kircheneer
Copy link
Contributor

Closing in favor of #377 - thanks @gioccher!

@Kircheneer Kircheneer closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants