Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul docs #468

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

Kircheneer
Copy link
Contributor

  • Start implementing some of the Diataxis Framework
  • Overhaul the developing jobs tutorial to make it more tutorial-ly
  • Fix a significant bug that never allowed jobs to run in non-dry-run mode

@Kircheneer Kircheneer self-assigned this Jun 12, 2024
@Kircheneer Kircheneer requested a review from a team as a code owner June 12, 2024 14:33
@Kircheneer Kircheneer force-pushed the lk-docs-update branch 3 times, most recently from 979d095 to c4fd5ac Compare June 13, 2024 13:05
@jdrew82 jdrew82 added the type: documentation Issues/PRs addressing documentation. label Aug 21, 2024
@Kircheneer Kircheneer force-pushed the lk-docs-update branch 4 times, most recently from 7b65b20 to ff8a9ce Compare November 19, 2024 10:22
Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tweaks and things to consider but this is a great start and I hope clearer for new developers.

docs/dev/jobs.md Outdated Show resolved Hide resolved
docs/dev/jobs.md Outdated Show resolved Hide resolved
docs/dev/jobs.md Outdated Show resolved Hide resolved
docs/dev/issues.md Show resolved Hide resolved
docs/dev/issues.md Show resolved Hide resolved
docs/dev/jobs.md Show resolved Hide resolved
docs/dev/jobs.md Outdated Show resolved Hide resolved
docs/dev/jobs.md Outdated

!!! note
You still want your models to adhere to the [modeling guide](../user/modeling.md), since it provides you the auto-generated `load` function for the diffsync adapter on the Nautobot side.
At this point, the job will show up in the web GUI, and you can enable it and even run it! You should see the objects you specified in the remote adapter being synchronized into Nautobot now. Also take a look at the "SSoT Sync Details" button in the top right of the job result page to get some more information on what diffsync is doing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
At this point, the job will show up in the web GUI, and you can enable it and even run it! You should see the objects you specified in the remote adapter being synchronized into Nautobot now. Also take a look at the "SSoT Sync Details" button in the top right of the job result page to get some more information on what diffsync is doing.
At this point, the Job will show up in the web GUI, at which point you can enable it and even run it! You should see the objects you specified in the remote Adapter being synchronized into Nautobot now. In addition, clicking on the "SSoT Sync Details" button in the top right of the Job result page provides additional information on what DiffSync is doing during the synchronization process.


!!! warning
Special care should be taken when synchronizing new Devices with children Interfaces into a Nautobot instance that also defines Device Types with Interface components of the same name. When the new Device is created in Nautobot, its Interfaces will also be created as defined in the respective Device Type. As a result, when SSoT will attempt to create the children Interfaces loaded by the remote adapter, these will already exist in the target Nautobot system. In this scenario, if not properly handled, the sync will fail! Possible remediation steps may vary depending on the specific use-case, therefore this is left as an exercise to the reader/developer to solve for their specific context.
The above example shows the simplest field type (an attribute on the model), however, to build a production implementation you will need to understand how to identify different variants of fields by following the [modeling docs](../dev/modeling.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The above example shows the simplest field type (an attribute on the model), however, to build a production implementation you will need to understand how to identify different variants of fields by following the [modeling docs](../dev/modeling.md).
The above example shows the simplest field type (an attribute on the model), however, to build a production implementation you will need to understand how to identify different variants of fields by following the [Modeling docs](../dev/modeling.md).

docs/user/app_getting_started.md Show resolved Hide resolved
Kircheneer and others added 4 commits December 19, 2024 15:37
Co-authored-by: Justin Drew <2396364+jdrew82@users.noreply.github.com>
Co-authored-by: Justin Drew <2396364+jdrew82@users.noreply.github.com>
Kircheneer and others added 3 commits December 19, 2024 15:45
Co-authored-by: Justin Drew <2396364+jdrew82@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Issues/PRs addressing documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants