-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap ssot integration #541
Conversation
Looks much better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some items to address.
nautobot_ssot/integrations/bootstrap/diffsync/adapters/nautobot.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some stuff to address.
Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nitpick to the docs. Also, I think you need to add yourself to the CODEOWNERS for this integration.
Also, please fix conflict with release notes for 1.5. |
…obot-app-ssot into bootstrap_ssot_integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add Bootstrap SSoT to sync in information from a local yaml file or git repository hosting information for various Nautobot "base" models.