Fix Bootstrap for DLM 3.0 and Correct Docs #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrew82
added
type: bug
| SoftwareLCM = apps.get_model("nautobot_device_lifecycle_mgmt", "SoftwareLCM") | ||
| signal_to_model_mapping["software"] = SoftwareLCM | ||
| except LookupError as err: | ||
| print(f"Unable to find SoftwareLCM model from Device Lifecycle Management App. {err}") |
There was a problem hiding this comment.
In my mind we should either.
- Rely on pyproject.toml to ensure we side step this issue by pinning / setting the proper versions of dependencies
- Support both new and old versions
The print to me would not be easily seen, and as far as I can tell, not let the customer know the issue is exactly.
There was a problem hiding this comment.
@itdependsnetworks The problem is this isn't a direct dependency. The Bootstrap integration supports both Golden Config and Device Lifecycle Management Apps. The problem is that with DLM's change to get rid of SoftwareLCM and SoftwareImageLCM we need to account for that with this integration as it was blowing up my testing of the DLM update.
bile0026
reviewed
Oct 24, 2024
…f SoftwareLCM/SoftwareImageLCM in DLM 3.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #585 and also updates the documentation on the Bootstrap integration to clarify installation and settings.