Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

v5.0 Changes #109

Merged
merged 8 commits into from Sep 8, 2022
Merged

v5.0 Changes #109

merged 8 commits into from Sep 8, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2022

No description provided.

@ghost ghost requested review from pke11y, chadell, scetron and whitej6 as code owners July 14, 2022 16:00
pyproject.toml Outdated Show resolved Hide resolved
@whitej6
Copy link
Contributor

whitej6 commented Aug 10, 2022

@pke11y can you pin flake8 to fix the linting issue? Below is what we do in golden config for that issue in the pyproject.toml.

# we need to pin flake8 because of package dependencies that cause it to downgrade and 
# therefore cause issues with linting since older versions do not take .flake8 as config
flake8 = "^3.9.2"

@pke11y
Copy link
Contributor

pke11y commented Aug 11, 2022

@whitej6 great, thanks for the info

@pke11y pke11y requested a review from whitej6 August 11, 2022 14:13
@ghost
Copy link
Author

ghost commented Aug 11, 2022

We are working on many new updates to 5.0 package. Will hopefully continue working on this next week.

Fixes for interfaces load
…hatops-ipfabric into develop

� Conflicts:
�	poetry.lock
@ghost ghost changed the title DRAFT V5.0 Changes v5.0 Changes Aug 17, 2022
@whitej6
Copy link
Contributor

whitej6 commented Aug 20, 2022

@justinjeffery-ipf is this ready for final review & merge? If so I will pull down and run a local instance to test.

@ghost
Copy link
Author

ghost commented Aug 22, 2022

@justinjeffery-ipf is this ready for final review & merge? If so I will pull down and run a local instance to test.

Yes however this will only work with IP Fabric version 5.0, all support for 4.4 was dropped.

@pke11y
Copy link
Contributor

pke11y commented Aug 23, 2022

@justinjeffery-ipf what's the incompatibility with v4 - the API URL?
I'm okay with moving to only supporting v5 on the next release. We'd just need to test to verify all is working okay.

@chadell
Copy link
Contributor

chadell commented Aug 23, 2022

I support a clear deprecation policy, something like we are doing in https://github.com/nautobot/nautobot-plugin-golden-config/blob/develop/docs/admin/admin_install.md#deprecation-policy

@ghost
Copy link
Author

ghost commented Aug 23, 2022

Table PR till Friday's meeting?

@whitej6
Copy link
Contributor

whitej6 commented Aug 23, 2022

Should I be on that call?

@pke11y
Copy link
Contributor

pke11y commented Aug 23, 2022

Should I be on that call?

@whitej6 will sync with you offline on this.

@whitej6 whitej6 merged commit 2797678 into nautobot:develop Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants