This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
find-host command #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadell
suggested changes
Jan 13, 2022
| for host in hosts: | ||
| for edge in host.get("edges"): | ||
| edge_details = " ".join([edge.get("hostname", ""), edge.get("intName", "")]) | ||
| host["edges"] = edge_details |
There was a problem hiding this comment.
I'm a bit confused by these fors. It looks like we can get multiple edges and gateways, but we only store the last?? 🤔
I guess I'm missing something here
There was a problem hiding this comment.
For all the data I have only one object is ever returned for these attributes. Will update to account for possible other elements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command to find a host in the inventory table. The use case was outlined by IP Fabric.
Current filters are
ipandmacvalidated usingnetutils.