-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
check if ssids are returned before returning them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am not sure that this solves the issue completely. I think it just postpones the problem. nautobot-plugin-chatops-ipfabric/nautobot_chatops_ipfabric/worker.py Lines 718 to 719 in 8bfe409
There we have two similar lines as before:
nautobot-plugin-chatops-ipfabric/nautobot_chatops_ipfabric/worker.py Lines 781 to 784 in 8bfe409
I am pretty sure we can update the first line similarly. The second needs a different fix.
I am not sure how to test this properly in our lab. |
I added some updates, but I am not sure if we can test that in our environment. I checked and we don't have any radio without the SSID in our IPFabric snapshot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
Fixes: #90