Update for Nautobot API 2.0 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pszulczewski
requested review from
jvanderaa,
jmcgill298 and
itdependsnetworks
as code owners
|
I need to digest these recommendations this: nautobot/nautobot#4372 then I'll update docs. |
|
Docs updated an re-based on next-2.0 after recent changes. Ready for review. |
jvanderaa
approved these changes
Sep 13, 2023
|
@pszulczewski do you want to merge this one on in? |
itdependsnetworks
added a commit
that referenced
this pull request
Oct 1, 2023
* First pass at 2.0 migration (for nautobot) and nornir-nautobot 3.0 * Update for Nautobot API 2.0 (#105) * Add tcp port configuration option * Update examples and docs. Replace PK with name and add a note. * Update logger * Fix dispatcher and a few missed log conversions * Unpin pynautobot dependency and fix black (#124) * fix tcp ping port (#125) * Blacken code. * Update changelog, add error codes to docs, fix misspell in class name, update loggers * Add migration docs * Update migration guide name to be more standard * Fix custom dispatcher, make error message more visible, add error code links to other repos --------- Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Josh VanDeraa <jv@networktocode.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still docs may need updates as names for locations don't guarantee location uniqueness.