Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial port to nautobot 2 #17

Merged
merged 21 commits into from
Oct 14, 2024
Merged

Initial port to nautobot 2 #17

merged 21 commits into from
Oct 14, 2024

Conversation

TobiPeterG
Copy link
Contributor

@TobiPeterG
Copy link
Contributor Author

This is an initial bring up, not tested. As nautobot/go-nautobot#30 is not merged yet, this code points to my go-nautobot repo.

How can I easily test the code?

@chadell
Copy link
Collaborator

chadell commented Sep 6, 2024

This is an initial bring up, not tested. As nautobot/go-nautobot#30 is not merged yet, this code points to my go-nautobot repo.

How can I easily test the code?

test it against your branch, and when it's ready, we update it here

@TobiPeterG
Copy link
Contributor Author

TobiPeterG commented Sep 6, 2024

This is an initial bring up, not tested. As nautobot/go-nautobot#30 is not merged yet, this code points to my go-nautobot repo.

How can I easily test the code?

test it against your branch, and when it's ready, we update it here

I tested it already with the demo Nautobot instance and everything seems to work. :)
I already added the functionality to add/read/update/delete cluster types, clusters and virtual machines

@TobiPeterG
Copy link
Contributor Author

@chadell please have a look, update to use official go-nautobot :)

@TobiPeterG TobiPeterG force-pushed the update-2.0 branch 2 times, most recently from fde1ac5 to e70e0ef Compare October 9, 2024 14:28
@@ -0,0 +1,28 @@
---
# generated by https://github.com/hashicorp/terraform-plugin-docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TobiPeterG could you update the readme to explain how you have generated the docs. thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated with the command "go generate" if I'm not mistaken, it's documented in the main.go

It is also automatically executed in the GitHub ci afaik :)

Copy link
Collaborator

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit afe2e56 into nautobot:main Oct 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants