Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept re-using existing idp for temporary environments #128

Closed
wants to merge 27 commits into from

Conversation

rocketnova
Copy link
Contributor

@rocketnova rocketnova commented Aug 5, 2024

Ticket

Resolves #{TICKET NUMBER OR URL}

Changes

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Preview environment

@lorenyu
Copy link
Collaborator

lorenyu commented Aug 14, 2024

@rocketnova can you merge main into this branch t fix the remaining CI errors

@rocketnova
Copy link
Contributor Author

rocketnova commented Aug 14, 2024

@lorenyu After merging in main, it looks like everything is passing except for the new e2e tests. I suspect that the sample app doesn't meet the accessibility requirements.

@lorenyu
Copy link
Collaborator

lorenyu commented Aug 14, 2024

suspect that the sample app doesn't meet the accessibility requirements.

haha yeah it seems that way. that's fine, at least it's running ok. i'll add a ticket to make sampe app pass the axe scan

@lorenyu
Copy link
Collaborator

lorenyu commented Aug 14, 2024

navapbc/template-infra#733

@lorenyu
Copy link
Collaborator

lorenyu commented Aug 14, 2024

@rocketnova navapbc/template-infra#734

@rocketnova
Copy link
Contributor Author

Merged in navapbc/template-infra#717

@rocketnova rocketnova closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants