This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
forked from HHS/simpler-grants-gov
-
Notifications
You must be signed in to change notification settings - Fork 0
[Issue #1757]: setup e2e tests for search #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
requested review from
aplybeah,
coilysiren,
jamesbursa,
chouinar,
andycochran and
acouch
as code owners
May 14, 2024 19:41
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 84.14% | 870/1034 |
🟡 | Branches | 65.01% | 223/343 |
🟡 | Functions | 75.58% | 164/217 |
🟢 | Lines | 84.18% | 809/961 |
Test suite run success
164 tests passing in 56 suites.
Report generated by 🧪jest coverage report action from ac2bf35
👀 |
coilysiren
approved these changes
May 14, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes # - Add e2e tests for search page - Add e2e test (with FE and API) to its own CI job (`ci-frontend-ci.yml`) - invokes shell script to wait until API is loaded
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HHS#1757
Time to review: 3 min
Changes proposed
ci-frontend-ci.yml
)Context
run with
npm run test:e2e
ornpm run test:e2e:ui
to run just the search test
npm run test:e2e -- tests/e2e/search.spec.ts
Screen.Recording.2024-05-08.at.8.59.02.PM.mov