[Task] Update analytics db to use local.env and Remove Dynaconf from Analytics

[aplybeah]

Summary

Fixes #107
Fixes #115

Time to review: 5 mins

Changes proposed

• removed the *.toml files related to dynaconf
• removed references to Dynaconf (e.g. in Docstrings, gitignore)
• use Pydantic for loading

Context for reviewers

After getting feedback for #107, the consensus was to reevaluate the way the database loader works for more uniformity. Changes will need to be made primarily in db.py and cli.py

With the PR #84 , the env settings for the db are stored in settings.toml. The config settings should be updated to use the existing local.env file

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

[coilysiren]

⭐⭐⭐   (must change before approval) These two need to retain their ANALYTICS_ prefix, or you need to change the terraform env var: https://github.com/navapbc/simpler-grants-gov/blob/main/infra/analytics/app-config/env-config/environment-variables.tf. Whichever you prefer.

[aplybeah]

Good catch! I'll keep the ANALYTICS prefix

[chouinar]

Does this work? I believe you need to instantiate the object in order to use the variables otherwise you're just using the class definition itself.

Something like

settings = DBSettings()
slackbot = slack.SlackBot(client=WebClient(token=settings.slack_bot_token))

[chouinar]

You'd want to use get_db_settings here as well.

[aplybeah]

@chouinar do you mean something like

def get_db_settings() -> DBSettings:
     return DBSettings()

def get_db() -> Engine:
# rest of code

[chouinar]

In a few other files you do:

from config import get_db_settings

settings = get_db_settings()

You need to do that here as well.

Just doing DBSettings.user isn't valid code - a quick test shows that would raise an AttributeError. DBSettings is the class, not an actual settings object.

--

Is this bit of code actually running in the tests? It should fail if run as written right now

[aplybeah]

I've been testing locally by running the actual make commands which (bizarrely) work. I'm in the process of double checking the tests.

[acouch]

@aplybeah any update on the suggested change?