This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
[Issue #174] Hide pagination component if no results are found #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@btabaska , great catch! |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 90.06% | 707/785 |
| 🟡 | Branches | 71.33% (+0.1% 🔼) |
204/286 |
| 🟢 | Functions | 86.31% | 145/168 |
| 🟢 | Lines | 90.75% | 667/735 |
Test suite run success
155 tests passing in 47 suites.
Report generated by 🧪jest coverage report action from d06a241
acouch
reviewed
Aug 26, 2024
| // PaginationPosition, | ||
| // } from "../../../src/components/search/SearchPagination"; | ||
|
|
||
| // import { render } from "@testing-library/react"; |
There was a problem hiding this comment.
👏🏿
*for removing commented out code
acouch
reviewed
Aug 26, 2024
| @@ -35,24 +35,28 @@ export default function SearchPagination({ | |||
| const pages = total || Number(totalPages); | |||
|
|
|||
| const updatePage = (page: number) => { | |||
| console.log("here"); | |||
There was a problem hiding this comment.
Looks like this got left here:
Suggested change
| console.log("here"); |
There was a problem hiding this comment.
Great catch. This should have been caught by linting. Filing a ticket to add no-console-statement to Eslint config
acouch
reviewed
Aug 26, 2024
| updateTotalPages(String(total)); | ||
| updateTotalResults(totalResults); | ||
| updateQueryParams(String(page), "page", query, scroll); | ||
| console.log("here2"); |
There was a problem hiding this comment.
This one too
Suggested change
| console.log("here2"); |
There was a problem hiding this comment.
Great catch, created. #181 to add no-console to eslint
|
@btabaska I found that if I click on the pager first, it doesn't disappear. Maybe if the page it is zero it should check and remove existing pagers, or we could just ignore this as it is not likely to happen often. Screenshare.-.2024-08-26.5_23_14.PM.mp4 |
acouch
approved these changes
Aug 27, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Fixes HHS#2040 > Updated pagination component to hide if there are no results. Previously it would show 7 pages that you could navigate between, all with no results. Updated all unit tests for pagination component. They were broken and commented out previously. 
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Fixes HHS#2040 > Updated pagination component to hide if there are no results. Previously it would show 7 pages that you could navigate between, all with no results. Updated all unit tests for pagination component. They were broken and commented out previously. 
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
…pbc#175) Fixes #2040 > Updated pagination component to hide if there are no results. Previously it would show 7 pages that you could navigate between, all with no results. Updated all unit tests for pagination component. They were broken and commented out previously. 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #174
Time to review: 8 mins
Changes proposed
Context for reviewers
Updated all unit tests for pagination component. They were broken and commented out previously.
Additional information