This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
forked from HHS/simpler-grants-gov
-
Notifications
You must be signed in to change notification settings - Fork 0
[Issue #186] Onboarding Documentation Improvements #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Improvements or additions to documentation
frontend
labels
Sep 6, 2024
mdragon
commented
Sep 6, 2024
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 90.06% | 707/785 |
🟡 | Branches | 71.33% | 204/286 |
🟢 | Functions | 86.31% | 145/168 |
🟢 | Lines | 90.75% | 667/735 |
Test suite run success
155 tests passing in 47 suites.
Report generated by 🧪jest coverage report action from 022a43e
…irm which is correct
…ode with the MS Markdown plugin
mdragon
force-pushed
the
mdragon/186-onboarding-improvements
branch
from
September 11, 2024 15:53
a535989
to
1fc51b0
Compare
Rebased after #190 merged to fix failing package vulnerability scan |
chouinar
reviewed
Sep 11, 2024
mdragon
requested review from
andycochran,
acouch and
sumiat
as code owners
September 12, 2024 14:19
chouinar
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mdragon
changed the title
#186 onboarding improvements
[Issue #186] Onboarding Documentation Improvements
Sep 13, 2024
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2034 > Cleaning up docs around getting onboarded to the project/repo > I walked through the READMEs and linked documentation to try to get things up and running on my new laptop without having to go to any outside sources of information (including you all) without adding that to the docs.
acouch
pushed a commit
that referenced
this pull request
Sep 18, 2024
Fixes HHS#2034 > Cleaning up docs around getting onboarded to the project/repo > I walked through the READMEs and linked documentation to try to get things up and running on my new laptop without having to go to any outside sources of information (including you all) without adding that to the docs.
acouch
pushed a commit
to HHS/simpler-grants-gov
that referenced
this pull request
Sep 18, 2024
Fixes #2034 > Cleaning up docs around getting onboarded to the project/repo > I walked through the READMEs and linked documentation to try to get things up and running on my new laptop without having to go to any outside sources of information (including you all) without adding that to the docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #186
Time to review: 2 mins
Changes proposed
Context for reviewers