Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Issue #186] Onboarding Documentation Improvements #193

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

mdragon
Copy link

@mdragon mdragon commented Sep 6, 2024

Summary

Fixes #186

Time to review: 2 mins

Changes proposed

Cleaning up docs around getting onboarded to the project/repo

Context for reviewers

I walked through the READMEs and linked documentation to try to get things up and running on my new laptop without having to go to any outside sources of information (including you all) without adding that to the docs.

@github-actions github-actions bot added documentation Improvements or additions to documentation frontend labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Coverage report for ./frontend

St.
Category Percentage Covered / Total
🟢 Statements 90.06% 707/785
🟡 Branches 71.33% 204/286
🟢 Functions 86.31% 145/168
🟢 Lines 90.75% 667/735

Test suite run success

155 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 022a43e

@mdragon mdragon force-pushed the mdragon/186-onboarding-improvements branch from a535989 to 1fc51b0 Compare September 11, 2024 15:53
@mdragon
Copy link
Author

mdragon commented Sep 11, 2024

Rebased after #190 merged to fix failing package vulnerability scan

documentation/api/development.md Show resolved Hide resolved
documentation/api/development.md Outdated Show resolved Hide resolved
@mdragon mdragon marked this pull request as ready for review September 12, 2024 14:19
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdragon mdragon changed the title #186 onboarding improvements [Issue #186] Onboarding Documentation Improvements Sep 13, 2024
@mdragon mdragon merged commit b0c93f2 into main Sep 13, 2024
12 checks passed
@mdragon mdragon deleted the mdragon/186-onboarding-improvements branch September 13, 2024 15:48
acouch pushed a commit that referenced this pull request Sep 18, 2024
Fixes HHS#2034

> Cleaning up docs around getting onboarded to the project/repo

> I walked through the READMEs and linked documentation to try to get
things up and running on my new laptop without having to go to any
outside sources of information (including you all) without adding that
to the docs.
acouch pushed a commit that referenced this pull request Sep 18, 2024
Fixes HHS#2034

> Cleaning up docs around getting onboarded to the project/repo

> I walked through the READMEs and linked documentation to try to get
things up and running on my new laptop without having to go to any
outside sources of information (including you all) without adding that
to the docs.
acouch pushed a commit to HHS/simpler-grants-gov that referenced this pull request Sep 18, 2024
Fixes #2034

> Cleaning up docs around getting onboarded to the project/repo

> I walked through the READMEs and linked documentation to try to get
things up and running on my new laptop without having to go to any
outside sources of information (including you all) without adding that
to the docs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Test and update onboarding steps
2 participants