Added basic support for local feature flagging #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses env variables - supports hot reload
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 93.02% (+16.48% 🔼) |
80/86 |
| 🟢 | Branches | 82.35% (+18.07% 🔼) |
14/17 |
| 🟢 | Functions | 93.33% (+21.9% 🔼) |
14/15 |
| 🟢 | Lines | 93.51% (+18.51% 🔼) |
72/77 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / MockAdapter.ts |
83.33% | 0% | 100% | 83.33% |
| 🟢 | ... / EvidentlyAdapter.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / server-utils.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / setup.ts |
100% | 50% | 100% | 100% |
Test suite run success
16 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from fbd37c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #263
Changes
LocalFeatureFlagManagerContext for reviewers
Ali had already implemented
FeatureFlagManagerfor managing prod flags via AWS Evidently. This simply adds a fallback for testing locally where a connection to Evidently might not be possible.