Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Docker NPM install script name #322

Merged
merged 1 commit into from
Apr 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ release-build:
##################################################
# Local development
##################################################
init: # Initialize the project for local development
container-npm-install: # Install NPM packages from within Docker
@# Install npm packages using Docker if node_modules doesn't exist
@if [ ! -d "node_modules" ]; then \
echo "Installing npm packages using Docker. This can take several minutes without output..."; \
Expand All @@ -45,7 +45,6 @@ init: # Initialize the project for local development
echo "node_modules directory already exists, skipping npm install"; \
fi


dev: # Run the Next.js local dev server in Docker
docker compose up --detach nextjs
docker compose logs --follow nextjs
Expand Down
4 changes: 2 additions & 2 deletions app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ Alternatively, you can run the application in a Docker container.

From the `app/` directory:

1. (Optional) Install Node packages to your local `node_modules` directory so tools like VSCode can provide intellisense and type checking
1. (Optional) If your machine doesn't include Node, and you'd like tools like VS Code to provide intellisense & type checking, run the following command to install the packages locally:
```bash
make init
make container-npm-install
```
1. Run the local development server
```bash
Expand Down
Loading