Finish running e2e tests even when one shard fails #783

rylew1 · 2024-11-15T23:50:20Z

Ticket

Resolves #720

wrap playwright merge cmd in make target e2e-merge-reports
set matrix fail-fast to false so reports can be generated if one of the shards fails
update docs for sharding

This PR tested on platform-test-nextjs => E2E sharding part 2 platform-test-nextjs#90
- See local demos there
Sharding part 1 PR Run e2e tests in parallel shards #776

Diff comparison with platform-test-nextjs PR:
That PR:

This PR:

lorenyu

LGTM but change PR title to imperative voice for example "Finish running e2e tests even when one shard fails"

.github/workflows/e2e-tests.yml

apply from platform-test-nextjs

0ea5d63

rylew1 requested review from lorenyu and coilysiren November 15, 2024 23:50

lorenyu approved these changes Nov 17, 2024

View reviewed changes

.github/workflows/e2e-tests.yml Outdated Show resolved Hide resolved

rylew1 changed the title ~~E2E sharding part 2~~ Finish running e2e tests even when one shard fails Nov 18, 2024

update comment

73e19f3

rylew1 merged commit 819442f into main Nov 18, 2024
7 checks passed

rylew1 deleted the rylew/e2e-sharding-part-2 branch November 18, 2024 01:52

rylew1 mentioned this pull request Nov 18, 2024

Add e2e-merge-reports target to phony list #784

Merged