-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Notifications #786
Open
coilysiren
wants to merge
8
commits into
main
Choose a base branch
from
kai/notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Email Notifications #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests passes
Ahah! This CI failure is relevant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves navapbc/platform-test#140
Changes
enable_notifications
throughout the configuration as it is now being usednotifications_email_domain
, meant to be deployed frommain
, which deploys an DNS records in service of validating an email identityexisting_notifications_email_domain
, meant be deployed from temporary environments, which uses data resources to pull fromnotifications_email_domain
notifications
, used in both of the above cases, which deploys an AWS Pinpoint application capable of sending emailsUsage Context
Grants.gov plans to use this for "transactional" emails, eg. password resets, status updates, etc.
Context for reviewers
This will be followed up by:
Testing
See navapbc/platform-test#141, specifically navapbc/platform-test#141 (comment)