Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] region color styling broken in v3.10 #3611

Closed
ebencollins opened this issue Jan 22, 2024 · 2 comments
Closed

[bug] region color styling broken in v3.10 #3611

ebencollins opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels

Comments

@ebencollins
Copy link
Contributor

Description

Regions created with "class" property no longer have their fill color since v3.10.

This seems to have happened in 0496ec6.

Expected (v3.9.4)

Actual (v3.10.3)

Steps to check or reproduce

  1. Add regions with class
  2. Specify style with fill color for class
  3. Observe region is still of default color

v3.10.3 (broken): https://stackblitz.com/edit/nisjec-buk5d2?file=index.ts
v3.9.4 (working): https://stackblitz.com/edit/nisjec-j5fxtt?file=index.ts

@netil
Copy link
Member

netil commented Jan 23, 2024

hi @ebencollins, thanks for the report.
It a side-effect of #3323, which updated region's rect element default css rule.

@netil netil added the bug label Jan 23, 2024
@netil netil self-assigned this Jan 23, 2024
netil pushed a commit to netil/billboard.js that referenced this issue Jan 23, 2024
update ".bb-region rect" rule to not interfere applying
regions.class rule

Ref naver#3611
@netil netil closed this as completed in 7e4fa71 Jan 23, 2024
@netil
Copy link
Member

netil commented Jan 23, 2024

@ebencollins for workaround w/o library udpate, specify rect in each selector to increase the specifity.
(this will work after the fix also)

  #styleForRegion .bb-region-0 rect {
    fill: red;
  }
  #styleForRegion .bb-region.foo rect {
    fill: green;
  }

github-actions bot pushed a commit that referenced this issue Feb 13, 2024
# [3.11.0-next.2](3.11.0-next.1...3.11.0-next.2) (2024-02-13)

### Bug Fixes

* **regions:** Fix applying regions class ([7e4fa71](7e4fa71)), closes [#3611](#3611)

### Features

* **arc:** Intent to ship arc.rangeText ([e887baf](e887baf)), closes [#2120](#2120)
* **gauge:** Intent to ship gauge.enforceMinMax ([c277201](c277201)), closes [#2125](#2125)
* **gauge:** Intent to ship gauge.label.ratio ([d4e49ba](d4e49ba)), closes [#3633](#3633)
github-actions bot pushed a commit that referenced this issue Feb 15, 2024
# [3.11.0](3.10.3...3.11.0) (2024-02-15)

### Bug Fixes

* **Axis:** Correct x axis height calculation for autorotated x axis tick texts ([d5b5d09](d5b5d09)), closes [#3584](#3584) [#3585](#3585)
* **axis:** Fix x Axis tick height calculation ([ac26f11](ac26f11)), closes [#3643](#3643)
* **axis:** Fixed x axis tick texts rotation when legend is positioned right ([ed4703e](ed4703e)), closes [#3570](#3570) [#3571](#3571)
* **packages:** Fix build error with moduleResolution:bundler ([9c17eea](9c17eea)), closes [#3541](#3541)
* **radar:** Fix axes texts exclusion on resize ([3a814a5](3a814a5)), closes [#3126](#3126)
* **regions:** Fix applying regions class ([7e4fa71](7e4fa71)), closes [#3611](#3611)
* **tooltip:** Fix tooltip position from interference ([9d28cbb](9d28cbb)), closes [#3575](#3575)
* **tooltip:** Fix wrong tooltip selection on browser scroll change ([#3593](#3593)) ([8f80637](8f80637)), closes [#3592](#3592)
* **zoom:** Fix zoom state on data load ([967207b](967207b)), closes [#3422](#3422)

### Features

* **arc:** Intent to ship arc.rangeText ([e887baf](e887baf)), closes [#2120](#2120)
* **axis:** Add x.tick.text.inner option ([cfc856c](cfc856c)), closes [#3552](#3552)
* **gauge:** Intent to ship gauge.enforceMinMax ([c277201](c277201)), closes [#2125](#2125)
* **gauge:** Intent to ship gauge.label.ratio ([d4e49ba](d4e49ba)), closes [#3633](#3633)
* **legend:** Itent to ship legend.format, legend.tooltip ([aecff2f](aecff2f)), closes [#3533](#3533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants