Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When point.sensitivity is a function then data.onclick is not working #3912

Closed
kisyov21 opened this issue Nov 5, 2024 · 7 comments
Closed
Labels

Comments

@kisyov21
Copy link

kisyov21 commented Nov 5, 2024

Description

With this ticket I am referring to the second issue from the already closed ticket - #3900
When point.sensitivity is a function then data.onclick is not working.

Steps to check or reproduce

check the code attached to #3900

@netil
Copy link
Member

netil commented Nov 7, 2024

Hi @kisyov21, the data.onclick will work based on the value poinst.senstivity returned from the function.

Checkout the example below, when senstivity is near bubble shape, the mouse cursor will change.
And when the pointer is within the senstivity value, data.onclick will work.

Nov-07-2024 12-20-52

So combining two options, point.senstivity fulfill the first requirement and when is in the boundary that's the moment which data.onclick work.

@netil netil added the practical label Nov 7, 2024
@kisyov21
Copy link
Author

kisyov21 commented Nov 7, 2024

@netil thanks for the response, but I think the jsfiddle link is wrong.. Can you please update it?

@netil
Copy link
Member

netil commented Nov 7, 2024

@kisyov21 updated the link

@kisyov21
Copy link
Author

kisyov21 commented Nov 7, 2024

@netil thank you for your time! I will check what might be the problem on my end.

@kisyov21
Copy link
Author

kisyov21 commented Nov 7, 2024

@netil actually I found why it is not working on my side. When the type is "timeseries" not "bubble", onclick is not fired. Is it by design or it is a bug?
https://jsfiddle.net/2ku058de/4/

@kisyov21
Copy link
Author

@netil Hi, did you have a chance to check what I sent above last week? It is a really important for me to understand is it a bug or there is something I missed in the documentation. Thanks in advance!

@netil
Copy link
Member

netil commented Nov 13, 2024

@kisyov21 quite busy these days. I'll go over it soon.

@netil netil added bug and removed practical labels Nov 14, 2024
netil pushed a commit to netil/billboard.js that referenced this issue Nov 14, 2024
Fix to consider point.sensitivity as function value when
determining mouse pointer is within the point

Ref naver#3912
@netil netil closed this as completed in 587d71e Nov 14, 2024
github-actions bot pushed a commit that referenced this issue Nov 18, 2024
## [3.14.1](3.14.0...3.14.1) (2024-11-18)

### Bug Fixes

* **point:** fix data.onclick working with sensitivity function ([587d71e](587d71e)), closes [#3912](#3912)
* **tooltip:** Hide tooltip on redraw when unexpected error ([3540640](3540640)), closes [#3909](#3909) [#3910](#3910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants