Dedicated reverse proxy documentation #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazygolem
force-pushed
the
reverse-proxy-auth-doc
branch
from
cb93e4c
to
c3a05a1
Compare
crazygolem
force-pushed
the
reverse-proxy-auth-doc
branch
from
c3a05a1
to
bb21f02
Compare
The security considerations are already centralized in a single page, it should not be changed for just one aspect of Navidrome. I also changed the HPP vulnerability section to make it less scary, as this is a pretty normal concern for reverse proxy authentication, and hopefully navidrome already plays nice with this. It is also not very usefull to mention hardening by stripping other credential sources without listing the sources (and I don't get exactly how all of them work yet).
crazygolem
force-pushed
the
reverse-proxy-auth-doc
branch
from
60e1302
to
285c305
Compare
crazygolem
force-pushed
the
reverse-proxy-auth-doc
branch
from
b6eb6c4
to
18057cd
Compare
crazygolem
force-pushed
the
reverse-proxy-auth-doc
branch
from
6bd2a83
to
5aa822a
Compare
|
Hey, thanks for this and sorry for not getting back to you sooner. I'll review it this week |
|
Hi @deluan, the PR is ready with the updates for navidrome/navidrome#3062. |
|
Nice! Will revise it before merging for the next release (in about a month) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to navidrome/navidrome#2558