[aksel.nav.no] Update examples of Page #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HalvorHaugan
commented
Nov 11, 2024
| @@ -161,6 +161,7 @@ const ComponentExamples = ({ node }: CodeExamplesProps) => { | |||
| invisible: unloaded, | |||
| }, | |||
| )} | |||
| style={{ maxHeight: "calc(100vh - 200px)" }} | |||
There was a problem hiding this comment.
This is to prevent the preview from taking up the entire viewport height.
There was a problem hiding this comment.
Can do this in className
"max-h-[calc(100vh-200px)]",
HalvorHaugan
commented
Nov 11, 2024
There was a problem hiding this comment.
TextWithMarkdownLink now also replaces backtics with code tags. What do you think?
Oh, maybe I should rename it to just TextWithMarkdown now?
There was a problem hiding this comment.
`TextWithMarkdown´ would be nice 👍
HalvorHaugan
commented
Nov 11, 2024
There was a problem hiding this comment.
Is this a good enough example of width=text?
KenAJoh
reviewed
Nov 12, 2024
| @@ -161,6 +161,7 @@ const ComponentExamples = ({ node }: CodeExamplesProps) => { | |||
| invisible: unloaded, | |||
| }, | |||
| )} | |||
| style={{ maxHeight: "calc(100vh - 200px)" }} | |||
There was a problem hiding this comment.
Can do this in className
"max-h-[calc(100vh-200px)]",
| */ | ||
| const TextWithMarkdownLink = ({ children: input }: { children: string }) => { | ||
| const regex = /\[([^\]]+)\]\(([^\s)]+)\)/g; | ||
| const regex = /\[([^\]]+)\]\(([^\s)]+)\)|`([^`]+)`/g; |
There was a problem hiding this comment.
Think this might deserve a comment now explaining what part of regex does what.
KenAJoh
approved these changes
Nov 13, 2024
KenAJoh
pushed a commit
that referenced
this pull request
Nov 15, 2024
JulianNymark
pushed a commit
that referenced
this pull request
Nov 19, 2024
JulianNymark
added a commit
that referenced
this pull request
Dec 3, 2024
* 🚧 wip * [Darkside] ErrorSummary updated CSS (#3331) * First run for errorsummary css update * Added nesting * [Darkside] Fileupload CSS update (#3343) * ✨ Updated Dropzone with darkmode * ♻️ Added nesting for root * ♻️ ac -> acx prefix for interla tokens * ♻️ Removed reduntant token * ♻️ More nesting * 💄 Align overlay on drag better * ⚰️ Removed test-code * 💄 Update hover-border for dropzone * 🐛 Removed border-color update on hover in disabled state * ♻️ Use bg input on area, use border default * [Darkside] Link CSS update (#3353) * ✨ Darkmode-support for existing link-component * :refactor: Adjusted line offsets and thickness * [Darkside] ExpansionCard CSS update (#3338) * 💄 Initial css-update expansioncard * 📝 Added sub-headers * 💫 Button animation * ✨ Added data attrb for open-state * 💫 Updated content animation * ♻️ Added nesting * ♻️ Better nesting of rules * ♻️ Use outline for hover border * ♻️ Use border as default outline * 🔥 Remove redundant border css * 🔥 Removed divider transition, unused state attributes in react * [aksel.nav.no] Update examples of Page (#3349) * Changesets: Run yarn as part of create-version * Combobox: Fix issue where using arrow keys in list would make the entire page scroll (#3364) * [Darkside] FormSummary updated CSS (#3345) * :refactor: Use updated CSS for darkside * 💄 Replace accent bg with info bg * [Docs] Use NAV-dekorator for Page examples (#3362) * [aksel.nav.no] Update examples of Page * comment * comment + rename + style->class * fix * 📝 Use NAV-dekorator for Page-examples * 🚚 Moved content to separate __parts location * :refactor: Updated examples * Update aksel.nav.no/website/components/website-modules/examples/__parts/PageDemoContent.tsx Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com> * 🐛 Use correct import syntax for parts * 📝 Add description to page-block default story * 💄 Removed spacing from all typo-headings in demo * 🐛 Removed react import from content part --------- Co-authored-by: Halvor Haugan <halvor.haugan@nav.no> Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com> * Git hooks that notify when yarn.lock have changed (#3361) * 💄 first pass css updates * 🎨 nest CSS * Datepicker: 💄 css layer changes & remove extra border * 🔥 remove resolved todo * 💄 border radius for caption buttons * 🎨 drastically simplify focus outline * change: make button selector less wildcardy * change: outline smaller for rdp-cell buttons * change: width large enough to show 4 characters in year caption * change: match design for range middle selected * change: remove redundant error CSS * change: remove unused CSS * change: un-shuffle css import ordering for date.css * change: remove unused CSS * change: week buttons & day button active * change: use secondary-neutral button for weeknumber buttons * change: same selector for month and day buttons, active state * 🐛 Fixed weeknumber as the button broke old datepicker * change: remove double border on captions, active state on disabled * ♻️ Updated weeknumber to be barkw-compat with old system * 🚚 Moved date-import further up --------- Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com> Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com> Co-authored-by: Halvor Haugan <halvor.haugan@nav.no> Co-authored-by: Ken <ken.aleksander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.