-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darkside] Warning triangle icon in error messages #3445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6646541 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo / Chromatic📝 Endringer til review: 14ef347f7bd | 91 komponenter | 135 stories |
JulianNymark
changed the title
Small changes discovered along the way
[darkside] Smaller changes / multiple components
Dec 10, 2024
JulianNymark
changed the title
[darkside] Smaller changes / multiple components
[Darkside] Smaller changes / multiple components
Dec 10, 2024
KenAJoh
reviewed
Dec 11, 2024
JulianNymark
changed the title
[Darkside] Smaller changes / multiple components
[Darkside] Warning triangle icon in error messages
Dec 18, 2024
This PR also changes the icons for old CSS (non-darkside) |
@navikt/core/react/src/typography/stories/error-message.stories.tsx
Outdated
Show resolved
Hide resolved
KenAJoh
reviewed
Dec 18, 2024
…ing, but probably no longer useful)
HalvorHaugan
approved these changes
Dec 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swap out error bullet / disc with our warning triangle icon.
Component Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")