[Darkside] Updated <Theme /> component
#3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook demo / Chromatic📝 Changes to review: 111a6c629c | 91 components | 135 stories |
KenAJoh
commented
Dec 19, 2024
HalvorHaugan
previously approved these changes
Dec 19, 2024
| ), | ||
| args: { | ||
| ...Default.args, | ||
| open: true, | ||
| }, | ||
| }; | ||
|
|
||
| export const BrandVolumeHigh: Story = { | ||
| /* High volume temp disabled until we agree on concept */ |
There was a problem hiding this comment.
ok to leave code commented out? (or shall we remove it and add when we know more later?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useThemeInternalsince potential "external" API might differ<Portal>will now preserve Theme when "portalled" outside the className-scope for.darkand.light.Note: Theme-component is still not exposed externally, so we can still make all the changes we want.
TODO: Might take inspiration from Chakra here, they have a little simpler API: https://github.com/chakra-ui/chakra-ui/blob/main/packages/react/src/components/theme.tsx
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")