Return an error tuple when a non-JSON response is received #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We saw an issue in production where our geo IP provider had an outage and was rendering an HTML error page, rather than sending the expected JSON request. With this PR, GeoIP.lookup/1 will return an error tuple rather than raising an exception.
Stacktrace from the issue we saw:
** (Jason.DecodeError) unexpected byte at position 0: 0x3C ("<")
(jason 1.3.0) lib/jason.ex:92: Jason.decode!/2
(geoip 0.2.7) lib/geoip/lookup.ex:56: GeoIP.Lookup.parse_response/1
(geoip 0.2.7) lib/geoip/lookup.ex:23: GeoIP.Lookup.lookup/1
Pull Request Test Coverage Report for Build a5df028a28e11426492f45e222f56d9bfb8df2f5-PR-34
💛 - Coveralls |
|
Great! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, let me say thanks for publishing such a useful "small, sharp tool" of a library. We've been happily using it in production for awhile now.☺️
We saw an issue today where our geo IP provider had an outage and was rendering an HTML error page, rather than sending the expected JSON request. With this PR,
GeoIP.lookup/1will return an error tuple in that case rather than raising an exception.Stacktrace from the issue we saw: