Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nav 173 results and discussion limitations #32

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Feature/nav 173 results and discussion limitations #32

merged 4 commits into from
Sep 24, 2024

Conversation

munterfi
Copy link
Member

A first version of the limitations.

@Brunner246 Can you check if the last two parapgraphs about the RAPTOR in C++ are correct?

@munterfi munterfi self-assigned this Sep 24, 2024
@munterfi munterfi added the documentation Improvements or additions to documentation label Sep 24, 2024
@munterfi
Copy link
Member Author

PS: We are not able to route on the GTFS of germany... somehow there are many invalid references. But it could also be a bug on our side. I would suggest fixing this or omit this in the thesis.

image

@Brunner246
Copy link
Contributor

@munterfi i would not start refactoring/bugfixing 2 days before submition 🙃

PS: We are not able to route on the GTFS of germany... somehow there are many invalid references. But it could also be a bug on our side. I would suggest fixing this or omit this in the thesis.

image

@munterfi
Copy link
Member Author

@munterfi i would not start refactoring/bugfixing 2 days before submition 🙃

PS: We are not able to route on the GTFS of germany... somehow there are many invalid references. But it could also be a bug on our side. I would suggest fixing this or omit this in the thesis.
image

Too late: naviqore/public-transit-service#122

@munterfi munterfi requested a review from Brunner246 September 24, 2024 12:17
clukas1
clukas1 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@clukas1 clukas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side.

@clukas1 clukas1 merged commit fe34782 into main Sep 24, 2024
@clukas1 clukas1 deleted the feature/NAV-173-results-and-discussion-limitations branch September 24, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brunner246 Brunner246 Brunner246 approved these changes

@clukas1 clukas1 clukas1 approved these changes

Assignees

@munterfi munterfi

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munterfi @Brunner246 @clukas1