Feature/nav 16 setup spring with rest #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tureTime parameter consistent over endpoints.
- Avoid boiler plate code, use lombok instead. - Add REST test file. - Rename api to app package, due to architectural overview.
munterfi
approved these changes
May 26, 2024
There was a problem hiding this comment.
Thanks @clukas1, nice work!
Sorry, somehow my suggestions ended up in this commit d947675, instead of suggestions from the IntelliJ GitHub integration. I have to study the GitHub integration a bit better some time 😄
The only thing, which does not work anymore is the test configuration of log4j. The debug logs are gone...
I think this is due to springboot dependency, which somehow overwrites the log configuration. Eventually we need to add a spring application.properites and an application-test.properties.
I will look for a solution tomorrow evening.
src/main/java/ch/naviqore/api/controller/ScheduleController.java
Outdated
Show resolved
Hide resolved
- Update log4j dependency. - Rename package and adjust package description. - Update README.md accordingly. - Move openapi.yml into same package.
|
Updating the log4j dependencies solved the problem of the missing debug level in the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First dummy implementation ready for review. If merged, I think we can start working on the Streamlit Frontend and Service Definition and Implementation in parallel.