Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/NAV-90-create-parent-stop-to-stops-map-in-gtfs-and-raise-warning-when-parent-stop-does-not-exist #50

Conversation

munterfi
Copy link
Member

@munterfi munterfi commented Jun 5, 2024

  • Parent stop ids can be blank strings in text input.
  • Adjust parser to check for this case
  • Remove Nullable parameter in addStop method of GTFS builder.

munterfi added 4 commits June 5, 2024 10:16
…arent_station column is mapped, then there will always be a string value, but most probably an empty one.
…arent_station column is mapped, then there will always be a string value, but most probably an empty one.
@munterfi munterfi requested a review from clukas1 June 5, 2024 08:32
@clukas1
Copy link
Member

clukas1 commented Jun 5, 2024

Changes look good, no additional comments.

@clukas1 clukas1 merged commit 4ec44c4 into main Jun 5, 2024
2 checks passed
@clukas1 clukas1 deleted the bugfix/NAV-90-create-parent-stop-to-stops-map-in-gtfs-and-raise-warning-when-parent-stop-does-not-exist branch June 6, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants