Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test/nav 77 integration test for rest controller #55

Merged
merged 14 commits into from
Jun 10, 2024
Merged

Test/nav 77 integration test for rest controller #55

merged 14 commits into from
Jun 10, 2024

Conversation

clukas1
Copy link
Member

@clukas1 clukas1 commented Jun 8, 2024

No description provided.

@clukas1 clukas1 requested a review from munterfi June 8, 2024 12:07
@clukas1 clukas1 self-assigned this Jun 8, 2024
munterfi added 5 commits June 10, 2024 17:19
@munterfi
TEST: NAV-77 - Extract constants
a64f7ab
@munterfi
STYLE: NAV-77 - Format changes
16a5069
@munterfi
ORG: NAV-77 - Remove example tests, since we now use mockito in our t…
dd3b08b 
…ests
@munterfi
TEST: NAV-77 - Open mocks using annotations, since it provides better…
a082ebc 
… validation by mockito

- Resolve UnnecessaryStubbingException, uncalled stubs.
- Just throw exceptions directly if they occur, no need to catch them and fail again.
@munterfi
TEST: NAV-77 - Lambda expressions instead of statements
3a4f753 
- Open mocks using annotations also in RoutingControllerTest.
- Again resolve UnnecessaryStubbingException, uncalled stubs.
- Resolve PotentialStubbingProblem.
@munterfi
Copy link
Member

Thanks @clukas1! I directly implemented my requests, so you can review again :)

  • Removed example package, since we dont need it anymore.
  • Open mocks with annotations, since mockito validation is better then (don't ask me why...).
  • Replace lampda statements with lambda expressions.
  • Directly throw checked exception, instead of caching and throwing them again (maybe i missed the point here?)

@clukas1
Copy link
Member Author

clukas1 commented Jun 10, 2024 •
edited
Loading

@munterfi: Changes look good but build was failing due to the extra argument introduced in the service config parser class. Fixed this and added more service config value validation tests. Please check and approve :)

@munterfi munterfi merged commit 92c332f into main Jun 10, 2024
2 checks passed
@munterfi munterfi deleted the test/NAV-77-Integration-Test-for-Rest-Controller branch June 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munterfi munterfi munterfi approved these changes

Assignees

@clukas1 clukas1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clukas1 @munterfi