Nav 104 simplify reduce return value for iso line rest api endpoint #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ized payload size for iso lines when requested.
…-Line-REST-API-Endpoint
…API-Endpoint' of github.com:naviqore/raptor into NAV-104-Simplify-reduce-return-value-for-Iso-Line-REST-API-Endpoint
munterfi
approved these changes
Jul 5, 2024
munterfi
deleted the
NAV-104-Simplify-reduce-return-value-for-Iso-Line-REST-API-Endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some refactoring of the API endpoints to allow smaller dtos for iso lines. The old return value for only the zürich tram network was 3 MB and is now done to 100 kB.
Some refactoring and more tests. I've introduced (a probably overkill) DummyService instead of mockito for the routing controller tests, the advantage being that we get more realistic return values for testing (although this might just be testing the dummyservice), however I think this might also be good when we start improving our error handling/reporting through the REST API.