Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nav 139 refactor and rename impl in the service package #94

Merged

Conversation

munterfi
Copy link
Member

Rename service implementation and solve open TODOs.

  • Update spring service according to CRON with new static GTFSs
  • Add test cases for no results found in getConnections and getIsolines.

- Name better reflects the specific implementation of the public transit service.
…ce with static GTFS

- Enable scheduling in spring boot application.
- Remove static update from public transit service interface, since it is GTFS specific.
- See `transfer.time.between.stops.minimum=${TRANSFER_TIME_BETWEEN_STOPS_MINIMUM:-1}`: If the value is set to -1, no additional transfers will be created.
@munterfi munterfi self-assigned this Aug 13, 2024
@munterfi munterfi requested a review from clukas1 August 13, 2024 19:53
Copy link
Member

@clukas1 clukas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the updater.

@clukas1 clukas1 merged commit 8692a53 into main Aug 13, 2024
2 checks passed
@munterfi munterfi deleted the feature/NAV-139-Refactor-and-rename-Impl-in-the-service-package branch August 13, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants