-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented functionality up to chapter 16 inclusive #2
Open
navkagleb
wants to merge
224
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove .vcxprojc.user files from project. Remove Win32 platform in third_party project. Update .gitignore file
Most of code in BlurPass is hardcoded, so it's need refactoring 1. Need to add new graphics command list (compute) and add interface to access it 2. Refactor Context. Move Resource Views binding to the Context. Move clearing of default render target from the Renderer to the Context 3. Move common code in blur.hlsl to functions 4. SwapChain shouldn't store Texture2D associated with back buffer. Need replace it with Texture2DResource
1. Move clearing render target and depth stencil to Context 2. Remove DepthStencil from SwapChain and move it to TestLayer. Remove m_BufferCount field 3. Rename Texture2D::GetResource to Texture2D::GetTexture2DResource
1. Remove unnecessary formats 2. Rename existing fields of enum
1. Create base class PipelineState 2. Rename PipelineState to GraphicsPipelineState and make in child class of PipelineState 3. Make ComputePipelineState child of PipelineState 4. Forbid to copy PipelineState
1. Add method to SetPipelineState to Context 2. Make cast operator private for PipelineState 3. Make Context friend of PipelineState
Made it possible to do shader permutations 1. THREAD_PER_GROUP_COUNT - how many threads will be in thread group 2. MAX_BLUR_RADIUS - the max radius that shader can support (depends on gauss weights)
1. MAX_BLUR_RADIUS move to const variable because there is no way to transfer data to array throw 32bit constants to shader. So Weight0 - Weight are left in Settings constant bufer 2. Replace Texture.Length to Texture.GetDimensions()
1. Create separate Root Signatures for Horizontal and Vertical blur passes 2. In TestLayer add ImGui widgets to control Horizontal and Vertical blur passes
Add missed parameter in Device::CreateTexture with TextureClearValue
When creating Texture throw device Texture2DConfig stores in Texture2D
Use this method when native resource (ID3D12Resource) already exists and it's need to be converted to Texture2DResource
- Added -no_adl_wrapperr -no_nvapi_wrapper command lines - Returned default value of Device::m_CompletedGpuFrameIndex to 0 - Rewrited condition when skip the deferred release in Device::ProcessDeferredRelease
- Replaced std::unordered_set with std::pmr::list in PipelineStateManager. std::pmr::list has better performance - Added the Bytes32 and Bytes64 class so that the type has the value that it represents
- Fixed error reporting when provided invalid command line argument - Use unsigned_integral for Bytes<T> - Rename g_InvalidIndex to g_InvalidUnsigned
- Added CommandLineArgs::g_IsPixCapturerEnabled - Added class PixCapturer
- ShaderCreation to ShaderInfo - Simpified Pso creation
- Added RenderViewportTool. In fact viewport for render targets - Added RenderSettingsTool. Tool separated in sections
…terType to DenoiserHistoryFix pass - Fixed bugs related to RenderViewportTool - Added dependecy on render viewport to RenderPass - Call RenderPass::OnRenderViewportSize only once per resizing - Replaced BottonPanelTool with PerformanceOverlayTool - Added FilterType to DenoiserHistoryFix pass - Added support of Min and Max sampler function - Updated UnifiedRootParameters shader - Refactored Runner class
- Create/Destroy interface - Unified interface for flippable and usual texture
Removed compile dependency (there is no more need to declare value in header file)
- Make names more understandable - Moved management of joint::CameraConstants to sandbox::GlobalConstantBufferPass
- Added functionality to get detached descriptor view for buffer (will need for GpuAssert implementation) - Moved std library helped functions to std_includes.hpp - Added GetStdHash function - Refactored Bytes class - Added LazyConverter class (needed for std::unordered_map::try_emplace
- Some Sigma denoiser implementation - Other small refactoring
- Also refactored texture implementation
- Separated Cpu visible and Gpu visible heap for resource descriptors (CBV, SRV, UAV) - Added ClearUnorderedAccess to GraphicsCommandList - Added IndexAllocator class - Added DeferredRelease method to Device for different resource types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.