Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use to_form helper for forms and refactor inputs #117

Merged
merged 15 commits into from
Mar 22, 2024
Merged

Use to_form helper for forms and refactor inputs #117

merged 15 commits into from
Mar 22, 2024

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Feb 20, 2024 •
edited
Loading

  • use to_form helper to create forms
  • refactor inputs to not rely on phoenix_html helper functions

@Flo0807 Flo0807 marked this pull request as draft February 20, 2024 17:33
@Flo0807 Flo0807 added the enhancement Changes that are not breaking label Mar 20, 2024
@Flo0807 Flo0807 changed the title Use new to_form syntax Use new to_form helper and refactor inputs Mar 20, 2024
@Flo0807 Flo0807 changed the title Use new to_form helper and refactor inputs Use new to_form helper and refactor inputs Mar 20, 2024
@Flo0807 Flo0807 marked this pull request as ready for review March 20, 2024 11:35
@Flo0807 Flo0807 added breaking-change A breaking change and removed enhancement Changes that are not breaking labels Mar 20, 2024
@Flo0807 Flo0807 changed the title Use new to_form helper and refactor inputs Use to_form helper for forms and refactor inputs Mar 20, 2024
@Flo0807 Flo0807 requested a review from pehbehbeh March 20, 2024 11:35
@Flo0807 Flo0807 self-assigned this Mar 20, 2024
pehbehbeh
pehbehbeh approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@pehbehbeh pehbehbeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactoring :) I only noted a few small things. You can merge on your own.

lib/backpex/html/form.ex Outdated Show resolved Hide resolved
lib/backpex/html/form.ex Show resolved Hide resolved
lib/backpex/html/resource.ex Outdated Show resolved Hide resolved
@Flo0807 Flo0807 merged commit 6c394d5 into develop Mar 22, 2024
11 checks passed
@Flo0807 Flo0807 deleted the feature/use-to-form branch March 22, 2024 11:09
@Flo0807 Flo0807 mentioned this pull request Apr 10, 2024
Merged
@Flo0807 Flo0807 mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pehbehbeh pehbehbeh pehbehbeh approved these changes

Assignees

@Flo0807 Flo0807

Labels
breaking-change A breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flo0807 @pehbehbeh