Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter label configurable in filter definition #226

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Apr 19, 2024

Add the possibility to configure filter label in filter map / definition:

@impl Backpex.LiveResource
def filters do
  [
    category_id: %{
      module: MyAppWeb.Filters.Category,
      label: "Category"
    },
  ]
end

If no label is specified in the filter definition map, the label from the filter module is used. Therefore, this change is not breaking.

@Flo0807 Flo0807 added the feature New feature label Apr 19, 2024
@Flo0807 Flo0807 self-assigned this Apr 19, 2024
@Flo0807 Flo0807 requested review from pehbehbeh and krns April 19, 2024 10:14
@pehbehbeh pehbehbeh merged commit 332cf33 into develop Apr 23, 2024
11 checks passed
@pehbehbeh pehbehbeh deleted the feature/make-filter-label-configurable-in-map branch April 23, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants