Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move filter_badge component to CoreComponents #444

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Move filter_badge component to CoreComponents #444

merged 8 commits into from
Jul 4, 2024

Conversation

makl9797
Copy link
Collaborator

@makl9797 makl9797 commented Jul 3, 2024

Makes the filter_badge component reusable for others and move it to the Backpex.HTML.CoreComponents module.

@makl9797 makl9797 added the enhancement Changes that are not breaking label Jul 3, 2024
@makl9797 makl9797 requested a review from Flo0807 July 3, 2024 10:48
@makl9797 makl9797 self-assigned this Jul 3, 2024
Flo0807
Flo0807 requested changes Jul 3, 2024
View reviewed changes
lib/backpex/html/core_components.ex Outdated Show resolved Hide resolved
@makl9797 @Flo0807
add default to clear_event attribute
f83fb22 
Co-authored-by: Florian Arens <60519307+Flo0807@users.noreply.github.com>
@Flo0807 Flo0807 merged commit a196261 into develop Jul 4, 2024
22 checks passed
@Flo0807 Flo0807 deleted the feature/move-filter-badge-component branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flo0807 Flo0807 Flo0807 requested changes

Assignees

@makl9797 makl9797

Labels
enhancement Changes that are not breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makl9797 @Flo0807