Check for named binding before joining #537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #530
This PR checks for a named binding before joining. It prevents an error being thrown if a join with the same alias has already been performed, e.g. in the
item_query
function.However, if we do not explicitly set an alias when joining in
item_query
this will not prevent a second join from being performed.Consider a post belonging to a user. If we define an item query like this.
maybe_join
will do a second join because there is no aliasuser
→has_named_binding/2
returns false.If we want to prevent a second join to be performed, we have to set the
user
alias explicitly: