Refactor Backpex.Fields.HasMany
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flo0807
force-pushed
the
feature/refactor-has-many
branch
from
57aed82
to
6cf2558
Compare
pehbehbeh
approved these changes
Sep 13, 2024
| @impl Backpex.Field | ||
| def before_changeset(changeset, attrs, _metadata, repo, field, assigns) do | ||
| {field_name, field_options} = field | ||
| validate_live_resource(field_name, field_options) |
There was a problem hiding this comment.
Things like this should be done way more generic and for every field / filter / etc. (in the future).
https://github.com/dashbitco/nimble_options
Maybe even on compile time.
Comment on lines
+86
to
+94
| defp validate_posts(changeset) do | ||
| posts = get_field(changeset, :posts) || [] | ||
|
|
||
| if length(posts) < 1 do | ||
| add_error(changeset, :posts, "must have at least one post") | ||
| else | ||
| changeset | ||
| end | ||
| end |
There was a problem hiding this comment.
Just an idea: We could provide a generic version of this via Backpex.Ecto.ChangesetHelpers.validate_assoc_length or something like that (in the future).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backpex.Field.HasManyto derive everything from the formbefore_changesetcallback to fieldsresource.ex(see upgrade guide)